2024-08-09 12:04:48 +00:00
|
|
|
/**
|
|
|
|
* @fileoverview Rule to enforce requiring named capture groups in regular expression.
|
|
|
|
* @author Pig Fang <https://github.com/g-plane>
|
|
|
|
*/
|
|
|
|
|
|
|
|
"use strict";
|
|
|
|
|
|
|
|
//------------------------------------------------------------------------------
|
|
|
|
// Requirements
|
|
|
|
//------------------------------------------------------------------------------
|
|
|
|
|
|
|
|
const {
|
|
|
|
CALL,
|
|
|
|
CONSTRUCT,
|
|
|
|
ReferenceTracker,
|
|
|
|
getStringIfConstant
|
2024-08-21 06:34:30 +00:00
|
|
|
} = require("@eslint-community/eslint-utils");
|
|
|
|
const regexpp = require("@eslint-community/regexpp");
|
2024-08-09 12:04:48 +00:00
|
|
|
|
|
|
|
//------------------------------------------------------------------------------
|
|
|
|
// Helpers
|
|
|
|
//------------------------------------------------------------------------------
|
|
|
|
|
|
|
|
const parser = new regexpp.RegExpParser();
|
|
|
|
|
2024-08-21 06:34:30 +00:00
|
|
|
/**
|
|
|
|
* Creates fixer suggestions for the regex, if statically determinable.
|
|
|
|
* @param {number} groupStart Starting index of the regex group.
|
|
|
|
* @param {string} pattern The regular expression pattern to be checked.
|
|
|
|
* @param {string} rawText Source text of the regexNode.
|
|
|
|
* @param {ASTNode} regexNode AST node which contains the regular expression.
|
|
|
|
* @returns {Array<SuggestionResult>} Fixer suggestions for the regex, if statically determinable.
|
|
|
|
*/
|
|
|
|
function suggestIfPossible(groupStart, pattern, rawText, regexNode) {
|
|
|
|
switch (regexNode.type) {
|
|
|
|
case "Literal":
|
|
|
|
if (typeof regexNode.value === "string" && rawText.includes("\\")) {
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case "TemplateLiteral":
|
|
|
|
if (regexNode.expressions.length || rawText.slice(1, -1) !== pattern) {
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
|
|
|
|
const start = regexNode.range[0] + groupStart + 2;
|
|
|
|
|
|
|
|
return [
|
|
|
|
{
|
|
|
|
fix(fixer) {
|
|
|
|
const existingTemps = pattern.match(/temp\d+/gu) || [];
|
|
|
|
const highestTempCount = existingTemps.reduce(
|
|
|
|
(previous, next) =>
|
|
|
|
Math.max(previous, Number(next.slice("temp".length))),
|
|
|
|
0
|
|
|
|
);
|
|
|
|
|
|
|
|
return fixer.insertTextBeforeRange(
|
|
|
|
[start, start],
|
|
|
|
`?<temp${highestTempCount + 1}>`
|
|
|
|
);
|
|
|
|
},
|
|
|
|
messageId: "addGroupName"
|
|
|
|
},
|
|
|
|
{
|
|
|
|
fix(fixer) {
|
|
|
|
return fixer.insertTextBeforeRange(
|
|
|
|
[start, start],
|
|
|
|
"?:"
|
|
|
|
);
|
|
|
|
},
|
|
|
|
messageId: "addNonCapture"
|
|
|
|
}
|
|
|
|
];
|
|
|
|
}
|
|
|
|
|
2024-08-09 12:04:48 +00:00
|
|
|
//------------------------------------------------------------------------------
|
|
|
|
// Rule Definition
|
|
|
|
//------------------------------------------------------------------------------
|
|
|
|
|
2024-08-21 06:34:30 +00:00
|
|
|
/** @type {import('../shared/types').Rule} */
|
2024-08-09 12:04:48 +00:00
|
|
|
module.exports = {
|
|
|
|
meta: {
|
|
|
|
type: "suggestion",
|
|
|
|
|
|
|
|
docs: {
|
2024-08-21 06:34:30 +00:00
|
|
|
description: "Enforce using named capture group in regular expression",
|
2024-08-09 12:04:48 +00:00
|
|
|
recommended: false,
|
2024-08-21 06:34:30 +00:00
|
|
|
url: "https://eslint.org/docs/latest/rules/prefer-named-capture-group"
|
2024-08-09 12:04:48 +00:00
|
|
|
},
|
|
|
|
|
2024-08-21 06:34:30 +00:00
|
|
|
hasSuggestions: true,
|
|
|
|
|
2024-08-09 12:04:48 +00:00
|
|
|
schema: [],
|
|
|
|
|
|
|
|
messages: {
|
2024-08-21 06:34:30 +00:00
|
|
|
addGroupName: "Add name to capture group.",
|
|
|
|
addNonCapture: "Convert group to non-capturing.",
|
2024-08-09 12:04:48 +00:00
|
|
|
required: "Capture group '{{group}}' should be converted to a named or non-capturing group."
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
create(context) {
|
2024-08-21 06:34:30 +00:00
|
|
|
const sourceCode = context.sourceCode;
|
2024-08-09 12:04:48 +00:00
|
|
|
|
|
|
|
/**
|
|
|
|
* Function to check regular expression.
|
2024-08-21 06:34:30 +00:00
|
|
|
* @param {string} pattern The regular expression pattern to be checked.
|
|
|
|
* @param {ASTNode} node AST node which contains the regular expression or a call/new expression.
|
|
|
|
* @param {ASTNode} regexNode AST node which contains the regular expression.
|
|
|
|
* @param {string|null} flags The regular expression flags to be checked.
|
2024-08-09 12:04:48 +00:00
|
|
|
* @returns {void}
|
|
|
|
*/
|
2024-08-21 06:34:30 +00:00
|
|
|
function checkRegex(pattern, node, regexNode, flags) {
|
2024-08-09 12:04:48 +00:00
|
|
|
let ast;
|
|
|
|
|
|
|
|
try {
|
2024-08-21 06:34:30 +00:00
|
|
|
ast = parser.parsePattern(pattern, 0, pattern.length, {
|
|
|
|
unicode: Boolean(flags && flags.includes("u")),
|
|
|
|
unicodeSets: Boolean(flags && flags.includes("v"))
|
|
|
|
});
|
2024-08-09 12:04:48 +00:00
|
|
|
} catch {
|
|
|
|
|
|
|
|
// ignore regex syntax errors
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
regexpp.visitRegExpAST(ast, {
|
|
|
|
onCapturingGroupEnter(group) {
|
|
|
|
if (!group.name) {
|
2024-08-21 06:34:30 +00:00
|
|
|
const rawText = sourceCode.getText(regexNode);
|
|
|
|
const suggest = suggestIfPossible(group.start, pattern, rawText, regexNode);
|
|
|
|
|
2024-08-09 12:04:48 +00:00
|
|
|
context.report({
|
|
|
|
node,
|
|
|
|
messageId: "required",
|
|
|
|
data: {
|
|
|
|
group: group.raw
|
2024-08-21 06:34:30 +00:00
|
|
|
},
|
|
|
|
suggest
|
2024-08-09 12:04:48 +00:00
|
|
|
});
|
|
|
|
}
|
|
|
|
}
|
|
|
|
});
|
|
|
|
}
|
|
|
|
|
|
|
|
return {
|
|
|
|
Literal(node) {
|
|
|
|
if (node.regex) {
|
2024-08-21 06:34:30 +00:00
|
|
|
checkRegex(node.regex.pattern, node, node, node.regex.flags);
|
2024-08-09 12:04:48 +00:00
|
|
|
}
|
|
|
|
},
|
2024-08-21 06:34:30 +00:00
|
|
|
Program(node) {
|
|
|
|
const scope = sourceCode.getScope(node);
|
2024-08-09 12:04:48 +00:00
|
|
|
const tracker = new ReferenceTracker(scope);
|
|
|
|
const traceMap = {
|
|
|
|
RegExp: {
|
|
|
|
[CALL]: true,
|
|
|
|
[CONSTRUCT]: true
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2024-08-21 06:34:30 +00:00
|
|
|
for (const { node: refNode } of tracker.iterateGlobalReferences(traceMap)) {
|
|
|
|
const regex = getStringIfConstant(refNode.arguments[0]);
|
|
|
|
const flags = getStringIfConstant(refNode.arguments[1]);
|
2024-08-09 12:04:48 +00:00
|
|
|
|
|
|
|
if (regex) {
|
2024-08-21 06:34:30 +00:00
|
|
|
checkRegex(regex, refNode, refNode.arguments[0], flags);
|
2024-08-09 12:04:48 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
};
|
|
|
|
}
|
|
|
|
};
|